D5312: KPasswordDialog: don't hide visibility action in plaintext mode

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D5312#100027, @fvogt wrote:
  
  > Tested locally, works fine!
  >
  > The behaviour is a bit unexpected, but IMO correct:
  >
  > - Enter a password
  > - Make it visible
  > - Delete it
  > - Toggle visibility -> VisibilityAction stays visible, although input empty and password hidden
  
  
  Good catch. Yes it's a bit inconsistent, but indeed the alternative (toggle visibility -> icon just disappears) is probably worse.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  kpassworddialog-leak

REVISION DETAIL
  https://phabricator.kde.org/D5312

To: elvisangelaccio, cfeck, fvogt
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170406/a2d3d9b7/attachment-0001.html>