D5319: Generate a moc_predefs.h file for KIOCore

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> CMakeLists.txt:165
> +if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
> +    execute_process(COMMAND "${CMAKE_CXX_COMPILER}" "-dM" "-E" "-c" "${CMAKE_ROOT}/Modules/CMakeCXXCompilerABI.cpp"
> +        OUTPUT_FILE ${CMAKE_CURRENT_BINARY_DIR}/moc_predefs.h

Shouldn't that be a rule with dependencies, so that it's not executed at every run of cmake? Or maybe just "if moc_predefs.h doesn't exist then..."

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5319

To: apol, #frameworks, dfaure, cgilles
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170406/17dd6652/attachment.html>