D5296: Use non-deprecated <gui> root element

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D5296#99818, @aacid wrote:
  
  > Do you know where we do the parsing that allows both gui and kpartgui to be "valid"?
  >
  > I did some searching and i think i found it but would be nice if you can find it and we agree on it D:
  
  
  What I found is that the parsing does not check the name of the root element, so <gui>, <kpartgui> or the more ancient <kpartplugin> (which I came across e.g. in some rc files KDevPlatform) all work. Or whatever else one might use, like <mylittlegui> ;)
  
  For code which does that, I think e.g. of  `KXMLGUIClient::setDOMDocument()` <https://phabricator.kde.org/source/kxmlgui/browse/master/src/kxmlguiclient.cpp;27d427965a1ee7745befd467c612b4debd6fea6d$345>, which just takes the `doc.documentElement()` of the passed DOM documents without any validation.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5296

To: kossebau, #frameworks
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170405/e9cb0697/attachment.html>