D5299: Fix KDirlister Gui Test setting URL scheme twice

Mark Gaiser noreply at phabricator.kde.org
Tue Apr 4 17:38:53 UTC 2017


markg added a reviewer: dfaure.
markg added inline comments.

INLINE COMMENTS

> kdirlistertest_gui.cpp:128-138
>      /*  lister->openUrl( home, KDirLister::Keep );
>        lister->openUrl( root, KDirLister::Keep | KDirLister::Reload );
>        lister->openUrl( QUrl::fromLocalFile("file:/etc"), KDirLister::Keep | KDirLister::Reload );
>        lister->openUrl( root, KDirLister::Keep | KDirLister::Reload );
>        lister->openUrl( QUrl::fromLocalFile("file:/dev"), KDirLister::Keep | KDirLister::Reload );
>        lister->openUrl( QUrl::fromLocalFile("file:/tmp"), KDirLister::Keep | KDirLister::Reload );
>        lister->openUrl( QUrl::fromLocalFile("file:/usr/include"), KDirLister::Keep | KDirLister::Reload );

Than the nearly all of this is also wrong.

I know the block is merely a comment, but can you fix that in the same manner?
That at least keeps it consistent consistent.

Or remove the block completely (if David Faure agrees).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5299

To: davidedmundson, #frameworks, kfunk, dfaure
Cc: markg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170404/1907cec6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list