Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Jan Grulich]

> On Zář. 29, 2016, 10:22 dop., Aleix Pol Gonzalez wrote:
> > Since I applied your patch, I get this output when starting plasma:
> > 
> > ```
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap &) Unhandled property "AllDevices"
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap &) Unhandled property "Devices"
> > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap &) Unhandled property "GlobalDnsConfiguration"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "LldpNeighbors"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "Real"
> > virtual void NetworkManager::DevicePrivate::propertyChanged(const QString &, const QVariant &) Unhandled property "S390Subchannels"
> > ```

You can ignore that, that was there even before. 

For "AllDevices" and "Devices" properties we ignore them intentionally, because there is also "DeviceAdded" and "DeviceRemoved" signal so there is no need to check that twice, maybe just supress the error message for those. For the rest we still don't have these properties implemented as they come from latest NM versions and we are a bit behind.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99656
-----------------------------------------------------------


On Zář. 29, 2016, 7:10 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> -----------------------------------------------------------
> 
> (Updated Zář. 29, 2016, 7:10 dop.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties at once, instead of initializing them one by one, which should significantly reduce number of blocking calls. Initialy I wanted to make this call asynchronous as well, but delayed initialization causes problems across the library so this is the easiest way how to do this.
> 
> 
> Diffs
> -----
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/manager_p.h 50c3c34 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160929/f7215235/attachment-0001.html>