Review Request 129065: Fix frameworks compilation with Qt < 5.6

Marco Martin notmart at gmail.com
Thu Sep 29 08:25:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/#review99654
-----------------------------------------------------------



are you sure they are completely interchangeable? (would have to have an ifdef otherwise)

- Marco Martin


On Sept. 28, 2016, 9:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129065/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 9:58 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
> in earlier Qt.
> 
> This shouldn't have any behavioural effect.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b 
> 
> Diff: https://git.reviewboard.kde.org/r/129065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160929/fe79d274/attachment.html>


More information about the Kde-frameworks-devel mailing list