Review Request 128115: do not load and debug in the same line

Harald Sitter sitter at kde.org
Wed Sep 28 08:55:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128115/
-----------------------------------------------------------

(Updated Sept. 28, 2016, 8:55 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Jeremy Whiting.


Repository: knewstuff


Description
-------

if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.

broke as result of review 126017

do not category debug in test

there's not much gain to be had from making tests less verbose, on the
contrary it might make debugging harder if something fails in an
isolated testbed (e.g. CI)


Diffs
-----

  autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d 

Diff: https://git.reviewboard.kde.org/r/128115/diff/


Testing
-------

makes && test passes


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160928/5064debd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list