Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129032/#review99577
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Sept. 26, 2016, 9:41 p.m., José Manuel  Santamaría Lema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129032/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 9:41 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Don't 'inline' public functions to avoid ABI breakage.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.h a85037a 
>   src/widgets/kpropertiesdialog.cpp 5f64478 
> 
> Diff: https://git.reviewboard.kde.org/r/129032/diff/
> 
> 
> Testing
> -------
> 
> When packaging kio for kubuntu we realized there was a couple of missing symbols which are a couple of deprecated functions, these functions were "inlined" (without using the 'inline' keyword). 
> This is the offending commit:
> https://quickgit.kde.org/?p=kio.git&a=commitdiff&h=b36d368f8004d949597fbe9dc83d6b70418c22f8
> 
> From the binary compatibility page "Do's and Don'ts":
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts
> You cannot...
> [...]
> For existing functions of any type:
> [...]
> inline it (this includes moving a member function's body to the class definition, even without the inline keyword).
> 
> The proposed patch moves the functions implementation from the .h file to the .cpp file so this way the binary compatibility is kept.
> 
> 
> Thanks,
> 
> José Manuel  Santamaría Lema
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160927/7f64d7fe/attachment.html>