Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129042/#review99575
-----------------------------------------------------------




src/accesspoint.cpp (line 69)
<https://git.reviewboard.kde.org/r/129042/#comment66964>

    Can you try to add a function to remove this annoying code duplication?


- Anthony Fieroni


On Sept. 27, 2016, 10:59 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129042/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:59 a.m.)
> 
> 
> Review request for KDE Frameworks, Network Management, Aleix Pol Gonzalez, and Lamarque Souza.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> Uses "GetAll" method from o.f.DBus.Properties interface to get all properties at once, instead of initializing them one by one, which should significantly reduce number of blocking calls. Initialy I wanted to make this call asynchronous as well, but delayed initialization causes problems across the library so this is the easiest way how to do this.
> 
> 
> Diffs
> -----
> 
>   src/accesspoint.cpp 60a284b 
>   src/activeconnection.cpp 1b66fc5 
>   src/activeconnection_p.h 60697e6 
>   src/adsldevice.cpp 8f9bbff 
>   src/bluetoothdevice.cpp eb839e0 
>   src/bonddevice.cpp 6d1899f 
>   src/bridgedevice.cpp 3c347af 
>   src/device.cpp 57538eb 
>   src/genericdevice.cpp 8f26617 
>   src/gredevice.cpp c1a59c5 
>   src/infinibanddevice.cpp 9bfa76f 
>   src/macvlandevice.cpp 9b3c75f 
>   src/manager.cpp d2f706e 
>   src/modemdevice.cpp 4bb4a23 
>   src/olpcmeshdevice.cpp 6f1212d 
>   src/settings.cpp 90e7267 
>   src/teamdevice.cpp d07b145 
>   src/tundevice.cpp 2a73012 
>   src/vethdevice.cpp 77b48b4 
>   src/vlandevice.cpp fdfa297 
>   src/vpnconnection.cpp 5dee6fc 
>   src/vpnconnection_p.h a8195ad 
>   src/wimaxdevice.cpp 6118f2f 
>   src/wireddevice.cpp 66bb649 
>   src/wirelessdevice.cpp 3f2972b 
> 
> Diff: https://git.reviewboard.kde.org/r/129042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160927/bab7cd7e/attachment-0001.html>