Review Request 128852: In listview mode use the default implemention of moveCursor

David Edmundson david at davidedmundson.co.uk
Tue Sep 27 00:14:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128852/
-----------------------------------------------------------

(Updated Sept. 27, 2016, 12:14 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kitemviews


Description
-------

KCategorizedView overrides the moveCursor to handle moving the cursor in
the grid; however it's own implementation doesn't handle key up/down
when it's not in an exact grid mode; which happens to also include list
mode.

In this case we don't need anything custom and the QListView
implementation works perfectly.

This fixes KPluginSelector keyboard navigation.


Diffs
-----

  src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 

Diff: https://git.reviewboard.kde.org/r/128852/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160927/91bfeb61/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list