Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

[David Faure]

> On Sept. 26, 2016, 9:53 a.m., Elvis Angelaccio wrote:
> > src/widgets/kfileitemactions.cpp, line 493
> > <https://git.reviewboard.kde.org/r/129019/diff/1/?file=477532#file477532line493>
> >
> >     There should be a `addedPlugins.append(jsonMetadata.pluginId());` after this line. For example I have ark installed both from distro package and in my own install prefix, so I get the ark actions twice.

Thanks for the test !

I debugged my duplicates, it was another issue: ark switching from a servicemenu desktop file to a plugin. Since I use "make install", I still had both in my install prefix, so both would appear. The historical solution to such issues was to install a ark_servicemenu.desktop file with Hidden=true in it, to overwrite the old file. Only useful to people who install from sources of course, binary packages don't need this.
Anyhow after a bit of install dir cleanup it works fine. I added your suggestion though, of course, for the issue you saw.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129019/#review99523
-----------------------------------------------------------


On Sept. 26, 2016, 8:10 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129019/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 8:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This was missing in KFileItemActions so apps had to implement
> this by themselves (this particular implementation is inspired by Dolphin's,
> while KonqPopupMenu only had support for .desktop files and not JSON metadata).
> 
> This API will also be useful in folderview (which I'm porting away
> from KonqPopupMenu) and kfind (same strategy).
> 
> 
> Diffs
> -----
> 
>   src/widgets/kfileitemactions.h 9b025549efdceef7f32dc461f3d5bfa2ee10d938 
>   src/widgets/kfileitemactions.cpp b31da0a38bfef634b0be207be9a87c9ba6864230 
>   src/widgets/kfileitemactions_p.h 3f669feb3cf54b61dcb7ad0a22bc005210e18899 
> 
> Diff: https://git.reviewboard.kde.org/r/129019/diff/
> 
> 
> Testing
> -------
> 
> Porting dolphin, folderview and kfind to this.
> 
> Still debugging why some service menu entries appear duplicated though - might or might not be related to this.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160926/bfc2bcfa/attachment.html>