Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

[Aleix Pol Gonzalez]

> On Sept. 26, 2016, 4:25 p.m., Aleix Pol Gonzalez wrote:
> > Again, I'll refer to how it's done in KCoreAddons. I don't think it's really useful to need to define variables for every framework you are compiling.
> 
> Luigi Toscano wrote:
>     Is this last sentence part of another conversation that I missed?
> 
> Ralf Habacker wrote:
>     This patch does it the same way as already implemented in kcoreaddons https://github.com/KDE/kcoreaddons/blob/master/KF5CoreAddonsConfig.cmake.in#L11.

The part I was referring to is actually:
```
if(CMAKE_CROSSCOMPILING AND KF5_HOST_TOOLING)
    find_file(TARGETSFILE KF5CoreAddons/KF5CoreAddonsToolingTargets.cmake PATHS ${KF5_HOST_TOOLING} ${CMAKE_CURRENT_LIST_DIR} NO_DEFAULT_PATH)
    include("${TARGETSFILE}")
else()
```

I don't think we should take into account CROSSCOMPILING if KF5_HOST_TOOLING isn't specified. Including the target files should define all the needed targets.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129025/#review99539
-----------------------------------------------------------


On Sept. 26, 2016, 4:23 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129025/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 4:23 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Enable cross compilation support for packages depending on normally installed kdoctools tools.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsConfig.cmake.in 9224fd2788aee5db4340cd0ac8115c1a06ca8ebe 
> 
> Diff: https://git.reviewboard.kde.org/r/129025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160926/f6719c7e/attachment.html>