Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)
Harald Sitter
sitter at kde.org
Mon Sep 26 12:10:31 UTC 2016
> On Sept. 26, 2016, 11:40 a.m., Aleix Pol Gonzalez wrote:
> > autotests/dupetest.cpp, line 66
> > <https://git.reviewboard.kde.org/r/129021/diff/1/?file=477536#file477536line66>
> >
> > It should mark an error if dupes found, no?
Doesn't QFAIL unwind the stack?
- Harald
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129021/#review99526
-----------------------------------------------------------
On Sept. 26, 2016, 11:27 a.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129021/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 11:27 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> run a duplicate detection program on the icon dir trees to detect
> duplicated icons which should be symlinked to reduce disk usage
>
> uses external program since otherwise we'd be needlessly reimplmenting what that program does (alas, couldn't find a lib)
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 9e3f841d951afb007cba3da79c217e9c2a3e38da
> autotests/dupetest.cpp PRE-CREATION
> autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d
>
> Diff: https://git.reviewboard.kde.org/r/129021/diff/
>
>
> Testing
> -------
>
> correctly detects all the nasty dupes
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160926/665f71d7/attachment.html>
More information about the Kde-frameworks-devel
mailing list