Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

David Faure faure at kde.org
Mon Sep 26 08:10:30 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129019/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kio


Description
-------

This was missing in KFileItemActions so apps had to implement
this by themselves (this particular implementation is inspired by Dolphin's,
while KonqPopupMenu only had support for .desktop files and not JSON metadata).

This API will also be useful in folderview (which I'm porting away
from KonqPopupMenu) and kfind (same strategy).


Diffs
-----

  src/widgets/kfileitemactions.h 9b025549efdceef7f32dc461f3d5bfa2ee10d938 
  src/widgets/kfileitemactions.cpp b31da0a38bfef634b0be207be9a87c9ba6864230 
  src/widgets/kfileitemactions_p.h 3f669feb3cf54b61dcb7ad0a22bc005210e18899 

Diff: https://git.reviewboard.kde.org/r/129019/diff/


Testing
-------

Porting dolphin, folderview and kfind to this.

Still debugging why some service menu entries appear duplicated though - might or might not be related to this.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160926/479e61e4/attachment.html>


More information about the Kde-frameworks-devel mailing list