Review Request 128790: Call utempter manually

[Martin Tobias Holmedahl Sandsmark]

> On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote:
> > a bit of delay due to vacation ...

no problem, I was in shenzhen myself.


> On Sept. 23, 2016, 5:17 a.m., Oswald Buddenhagen wrote:
> > cmake/FindUTEMPTER.cmake, line 53
> > <https://git.reviewboard.kde.org/r/128790/diff/5/?file=476595#file476595line53>
> >
> >     i suppose it would make sense to keep it, but with the executable.

I don't think mark_as_advanced() is appropriate, it makes sense to allow packagers to manually specify the path.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/#review99479
-----------------------------------------------------------


On Sept. 9, 2016, 4:50 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128790/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 4:50 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Oswald Buddenhagen, Rex Dieter, and Thiago Macieira.
> 
> 
> Bugs: 364779
>     https://bugs.kde.org/show_bug.cgi?id=364779
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child process).
> 
> So instead we invoke it manually with QProcess.
> 
> 
> Diffs
> -----
> 
>   cmake/FindUTEMPTER.cmake a3ea06a 
>   src/CMakeLists.txt caab96f 
>   src/kpty.cpp 15c3b81 
>   src/kpty_p.h 192bf1c 
> 
> Diff: https://git.reviewboard.kde.org/r/128790/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160925/11df3431/attachment.html>