Review Request 128966: Don't include kdeglobals when dealing with a cache config

Marco Martin notmart at gmail.com
Wed Sep 21 09:42:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/#review99348
-----------------------------------------------------------


Ship it!




good catch

- Marco Martin


On Sept. 21, 2016, 6:13 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128966/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 6:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The svg elements cache isn't really a "configuration" and it's not
> something that should be overridden by global config settings.
> 
> Loading it as a simple config skips the cascading and saves reparsing
> kdeglobals.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 
> 
> Diff: https://git.reviewboard.kde.org/r/128966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160921/dd73f4b1/attachment.html>


More information about the Kde-frameworks-devel mailing list