Review Request 128951: Load user's avatar from AccountsService if it exists
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Sep 19 22:03:27 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128951/#review99287
-----------------------------------------------------------
src/lib/CMakeLists.txt (line 13)
<https://git.reviewboard.kde.org/r/128951/#comment66856>
Use CMAKE_INSTALL_FULL_LOCALSATEDIR instead of CMAKE_INSTALL_LOCALSTATEDIR.
src/lib/util/kuser_unix.cpp (line 187)
<https://git.reviewboard.kde.org/r/128951/#comment66855>
http://agateau.com/2015/qdir-separator-considered-harmful/
- Aleix Pol Gonzalez
On Sept. 19, 2016, 11:56 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128951/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 11:56 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Plasma's UserManager (and Gnome) both now use AccountsService to store
> user information.
>
> AccountsService saves the account information, and more particularly the
> avatar, in /var. This is very useful for login managers that need to
> load them without having to deal with mounting remote or encrypted home
> directories.
>
> This patch makes KUser return the avatar saved by AccountsService first
> if it exist.
>
>
> Diffs
> -----
>
> src/lib/CMakeLists.txt 437c07e292d4f3e733a6609ddc4b7f8dc3649aab
> src/lib/util/config-accountsservice.h.cmake PRE-CREATION
> src/lib/util/kuser_unix.cpp 3cb1ee6070f8acba2b090f827eb99c79bf73a77f
>
> Diff: https://git.reviewboard.kde.org/r/128951/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160919/c7f66a36/attachment.html>
More information about the Kde-frameworks-devel
mailing list