Review Request 128916: kconfig: Make test XFAIL when running as root

[Gleb Popov]

> On Sept. 15, 2016, 3:01 p.m., Gleb Popov wrote:
> > autotests/kconfigtest.cpp, line 1378
> > <https://git.reviewboard.kde.org/r/128916/diff/1/?file=476914#file476914line1378>
> >
> >     I'd put both `cgLocal.writeEntry("someLocalString", "whatever2");` and `QVERIFY(!cgLocal.sync());` inside else clause.

After looking at `QEXPECT_FAIL()` documentation, i've figured you are right.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128916/#review99210
-----------------------------------------------------------


On Sept. 15, 2016, 4:20 p.m., Evgeniy Sadovnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128916/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 4:20 p.m.)
> 
> 
> Review request for KDE Frameworks and Gleb Popov.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The test checks that saving a read-only config file fails. But because root can write into read-only files, the test is failing when running by root.
> Check for uid when running the test and make it XFAIL if we are running as root.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 2b905b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Evgeniy Sadovnik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160915/22d3e8f1/attachment.html>