Review Request 128913: add a test to prevent file names from having newlines

Harald Sitter sitter at kde.org
Thu Sep 15 08:10:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128913/
-----------------------------------------------------------

(Updated Sept. 15, 2016, 8:10 a.m.)


Review request for KDE Frameworks.


Changes
-------

more generic function using qstring::simplified to detect all sorts of unprintable rubbish characters


Repository: breeze-icons


Description
-------

there is no reason for why they should. packaging systems take offense. so
do I.


Diffs (updated)
-----

  autotests/CMakeLists.txt 5c561c712322e1b90fdd2806ba4ce4011be2ad14 
  autotests/newlinetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128913/diff/


Testing
-------

makes and fails current master since it has broken files


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160915/a73a383a/attachment.html>


More information about the Kde-frameworks-devel mailing list