Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128892/
-----------------------------------------------------------

(Updated Sept. 12, 2016, 12:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa.


Changes
-------

Submitted with commit 02047b524a176da447d8c96e15c7e2abae8339ae by Christoph Cullmann to branch master.


Repository: baloo


Description
-------

At the moment, any application that uses baloo can corrupt the db.
Now, only the things that need to write to it open it with read-write.
This only works as long as the library exposes only read-only things like Query/...


Diffs
-----

  src/engine/database.h 6ccb2a5 
  src/engine/database.cpp 6a433c7 
  src/file/extractor/app.cpp 0ca7276 
  src/lib/file.cpp cbbc912 
  src/lib/searchstore.cpp 060a4fd 
  src/lib/taglistjob.cpp 76ac8ff 
  src/qml/experimental/monitor.cpp 11c06ae 
  src/tools/balooctl/main.cpp 2a6b175 
  src/tools/balooctl/statuscommand.cpp 1a56c64 
  src/tools/balooshow/main.cpp f45f2e0 

Diff: https://git.reviewboard.kde.org/r/128892/diff/


Testing
-------

Unit tests still work, balooctl seems to do something.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/e9aacd1c/attachment.html>