Taking over maintainership of Baloo

[Christoph Cullmann]

Hi,

> Hi,
> 
> indeed I also did take a look at the bug list, and out of the 200
> bugs, without much exaggeration almost all of them are crashes.
> 
> In fact, I believe it's important to CC the plasma-devel mailing list
> here: Given we are about to release a LTS Plasma 5.8, and baloo is
> tightly integrated into Plasma, Plasma will still contain lots and
> lots of crashes.
> 
> Maybe the Plasma people are also interested in taking e.g. 2-3 days to
> look into this.
> 
> Greetings,
> Dominik
> 
> PS: Many crashes are probably due to missing error checks, e.g.: in
> postingdb.cpp:
> 
>    int rc = mdb_get(m_txn, m_dbi, &key, &val);
>    if (rc == MDB_NOTFOUND) {
>        return 0;
>    }
>    Q_ASSERT_X(rc == 0, "PostingDB::iter", mdb_strerror(rc));
> 
>    return new DBPostingIterator(val.mv_data, val.mv_size);
> 
> Looking into the API documentation, mdb_get() [1] says:
>  Returns: A non-zero error value on failure and 0 on success. Some
> possible errors are:
>     MDB_NOTFOUND - the key was not in the database.
>     EINVAL - an invalid parameter was specified.
> 
> Note the "Some possible errors", there are many many more. The code
> should probably be if (rc != 0) return 0; etc. Baloo has tons of this
> bugs.
> 
> [1]
> http://104.237.133.194/doc/group__mdb.html#ga8bf10cd91d3f3a83a34d04ce6b07992d

I triaged now > 100 crash bugs, more or less everything boils down to the
non-existing error handling or out of space.

Greetings
Christoph

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234