Review Request 128891: Transaction not created => don't try to abort them

[Boudhayan Gupta]

> On Sept. 12, 2016, 12:25 a.m., Boudhayan Gupta wrote:
> > LGTM.
> > 
> > Long term I plan to replace all of this with liblmdb++, but that may or may not happen soon-ish.
> 
> Christoph Cullmann wrote:
>     Hi, lmdb++ is IMHO no good idea, look at their commits, last one 7 months ago, only 2 people ever did anything.
>     https://github.com/bendiken/lmdbxx
>     No good idea to rely on that. (and it has exactly zero unit tests)

In that case, I'll have to tidy this code up and make a clean wrapper around the C API. *sigh*


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128891/#review99107
-----------------------------------------------------------


On Sept. 12, 2016, 12:43 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128891/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 12:43 a.m.)
> 
> 
> Review request for KDE Frameworks and Boudhayan Gupta.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Transaction not created => don't try to abort them, avoid wrong usage of lmdb api
> 
> 
> Diffs
> -----
> 
>   src/engine/database.cpp 6a433c7 
> 
> Diff: https://git.reviewboard.kde.org/r/128891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/d693668e/attachment.html>