Review Request 128890: Make e.g. Baloo::Query thread safe.

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128890/
-----------------------------------------------------------

(Updated Sept. 11, 2016, 9:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Boudhayan Gupta.


Changes
-------

Submitted with commit e34da150d82a57cf417a59b8b632b2fecb32a6f7 by Christoph Cullmann to branch master.


Repository: baloo


Description
-------

lmdb itself is thread safe (e.g. you can use the same env in multiple threads).
Unfortunately, the Baloo::Database itself not, as open() might race against other open calls (we have one unique db object in baloo).

=> add non-recursive mutex (recursive mutex not needed, one just must avoid to call isOpen() or path() inside open, that is done, else no unit test works).


Diffs
-----

  src/engine/database.h e3bb175 
  src/engine/database.cpp ec7ae2e 

Diff: https://git.reviewboard.kde.org/r/128890/diff/


Testing
-------

Unit tests still work.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/98fa8678/attachment.html>