Review Request 128885: Increase size limit of baloo index for 64-bit machines

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128885/
-----------------------------------------------------------

(Updated Sept. 11, 2016, 4:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak Ahuja.


Changes
-------

Submitted with commit b0890aca71aa4f0fdabe65ee7b7fbd0bc844d8b8 by Christoph Cullmann to branch master.


Repository: baloo


Description
-------

Increase size limit of baloo index for 64-bit machines to avoid crashs after > 5GB of index size.
(Better would be additional out-of-space handling, but ATM baloo has zero checks for that)

The size limit for 32-bit is still 1GB, like before (there was a silent overflow from 5GB to 1GB in the computation), people with large homes will still get random segfaults on 32-bit.

Patch based on patch from Hao Zhang, Bug 364475
https://bugs.kde.org/show_bug.cgi?id=364475


Diffs
-----

  src/engine/database.cpp 89e2e03 
  src/engine/databasesize.h aa180fb 
  src/engine/transaction.cpp 0af20be 
  src/tools/balooctl/statuscommand.cpp 73289c4 

Diff: https://git.reviewboard.kde.org/r/128885/diff/


Testing
-------


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/a58e0f90/attachment.html>