Review Request 128889: Fix KFileItem::overlays returning empty string values

David Faure faure at kde.org
Sun Sep 11 15:55:24 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128889/#review99094
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On sep. 11, 2016, 3:40 après-midi, Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128889/
> -----------------------------------------------------------
> 
> (Updated sep. 11, 2016, 3:40 après-midi)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KFileItem::overlays always returns a string list with an empty string as the list's first element.
> For example, 
> for a symlink the list will be like this: {"", emblem-symbiolic-link}
> and for a plain text file it'll be like : {""} (here it should be completely empty, size=0)
> This patch attempts to fix the issue.
> 
> 
> Diffs
> -----
> 
>   src/core/kfileitem.cpp b5ed5fd 
> 
> Diff: https://git.reviewboard.kde.org/r/128889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/6ff60b7a/attachment.html>


More information about the Kde-frameworks-devel mailing list