Review Request 128886: odf files with no content.xml crash indexer

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128886/#review99085
-----------------------------------------------------------



lgtm


autotests/odfextractortest.cpp (line 103)
<https://git.reviewboard.kde.org/r/128886/#comment66713>

    Either set a parent or use QScopedPointer?


- Kai Uwe Broulik


On Sept. 11, 2016, 11:18 vorm., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128886/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2016, 11:18 vorm.)
> 
> 
> Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak Ahuja.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> Make odf indexer more error prove, check if the files are there (and are files at all) (meta.xml + content.xml)
> 
> 
> Diffs
> -----
> 
>   autotests/odfextractortest.h 3e6a1c7 
>   autotests/odfextractortest.cpp bea3640 
>   src/extractors/odfextractor.cpp 948f3e0 
> 
> Diff: https://git.reviewboard.kde.org/r/128886/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests, before, the missing content.xml did directly segfault baloo and co.
> 
> See Bug 364748
> https://bugs.kde.org/show_bug.cgi?id=364748
> 
> 
> File Attachments
> ----------------
> 
> missing content test
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/11/12206883-a130-4335-bb35-7514d832dc81__test_missing_content.odt
> missing meta test
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/11/eb7bdd4b-f2d5-4501-bd88-9ae492bb67d8__test_missing_meta.odt
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/4868586d/attachment.html>