Review Request 128882: Fix launching terminal .desktop files with konsole

[Antonio Rojas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128882/
-----------------------------------------------------------

(Updated Sept. 10, 2016, 7:15 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Leave %i alone, --icon still works in qt5


Repository: kio


Description
-------

Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole.


Diffs (updated)
-----

  src/core/desktopexecparser.cpp c526da7 

Diff: https://git.reviewboard.kde.org/r/128882/diff/


Testing
-------

.desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160910/49649d51/attachment.html>