Review Request 128790: Call utempter manually

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Fri Sep 9 04:50:57 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/
-----------------------------------------------------------

(Updated Sept. 9, 2016, 4:50 a.m.)


Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Oswald Buddenhagen, Rex Dieter, and Thiago Macieira.


Bugs: 364779
    https://bugs.kde.org/show_bug.cgi?id=364779


Repository: kpty


Description
-------

According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child process).

So instead we invoke it manually with QProcess.


Diffs (updated)
-----

  cmake/FindUTEMPTER.cmake a3ea06a 
  src/CMakeLists.txt caab96f 
  src/kpty.cpp 15c3b81 
  src/kpty_p.h 192bf1c 

Diff: https://git.reviewboard.kde.org/r/128790/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160909/47e14225/attachment.html>


More information about the Kde-frameworks-devel mailing list