Review Request 128650: [KBookmarks] Port from QRegExp to QRegularExpression

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128650/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 10:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 68db76e9d8afce989d246768ebed7a12f9414b34 by Daniel Vrátil to branch master.


Repository: kbookmarks


Description
-------

Kleopatra was crashing on shutdown during cleanup of global statics with QRegExps. Based on [0] I was able to trace the pointer back to .rodata in libKF5KBookmarks.so. This ports to QRegularExpression, which is not affected by the issue explained in [0].


[0] https://blogs.kde.org/2015/11/05/qregexp-qstringliteral-crash-exit


Diffs
-----

  src/kbookmarkimporter_ie.cpp 7dcbfb3 
  src/kbookmarkmanager.cpp dd7a98b 

Diff: https://git.reviewboard.kde.org/r/128650/diff/


Testing
-------


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160908/956f5ef2/attachment.html>