Review Request 128865: baloo_file crash fix - if database can't be created, try to cleanup and recreate

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128865/
-----------------------------------------------------------

(Updated Sept. 8, 2016, 10:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit a03b0caa4ca1fbfc249bfc0c2730aac340bbf929 by Christoph Cullmann to branch master.


Repository: baloo


Description
-------

ATM, I think baloo is missing a lot of checks for "mdb has seen problems".

Easiest case: you have a corrupted index database (easy to reproduce: echo BLA >> index in the baloo .local/... directory)

=> start baloo_file => directly crashs

Fix: try to create db, honor success, cleanup, try to create again, if still broken => exit


Diffs
-----

  src/file/main.cpp 9410635 

Diff: https://git.reviewboard.kde.org/r/128865/diff/


Testing
-------

Corrupted DB via

[cullmann at gekko baloo]$ pwd
/home/cullmann/.local/share/baloo
[cullmann at gekko baloo]$ echo skljdflksjdf >> index

=> started baloo_file

=> old version: will segfault for ever on each start
=> new version: works after cleanup


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160908/cb1c65a1/attachment.html>