Review Request 128855: Fix build on Windows

Gleb Popov 6yearold at gmail.com
Wed Sep 7 18:32:42 UTC 2016



> On Sept. 7, 2016, 9:24 p.m., Kevin Funk wrote:
> > `kioglobal_p.h` defines those. Just include that one?

Yep, you are right, this fixes build too. Ok to commit this one-liner?

```
+ #include "kioglobal_p.h"
```


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128855/#review98981
-----------------------------------------------------------


On Sept. 7, 2016, 6:23 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128855/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 6:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Windows doesn't have `S_IRUSR` & co defines, so use what it has and stub out remainings.
> 
> 
> Diffs
> -----
> 
>   src/core/slavebase.cpp 4b8f460 
> 
> Diff: https://git.reviewboard.kde.org/r/128855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160907/68a51cde/attachment.html>


More information about the Kde-frameworks-devel mailing list