Review Request 128852: In listview mode use the default implemention of moveCursor

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128852/#review98943
-----------------------------------------------------------



This patch fixes keyboard navigation in KDevelop's plugin config page, so obviously an improvement.

Another review won't hurt, though.

- Dominik Haumann


On Sept. 6, 2016, 3:45 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128852/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 3:45 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemviews
> 
> 
> Description
> -------
> 
> KCategorizedView overrides the moveCursor to handle moving the cursor in
> the grid; however it's own implementation doesn't handle key up/down
> when it's not in an exact grid mode; which happens to also include list
> mode.
> 
> In this case we don't need anything custom and the QListView
> implementation works perfectly.
> 
> This fixes KPluginSelector keyboard navigation.
> 
> 
> Diffs
> -----
> 
>   src/kcategorizedview.cpp 7e60a38060dc18fbe546495cfb0fdd64ec5b95d1 
> 
> Diff: https://git.reviewboard.kde.org/r/128852/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160906/e2231321/attachment.html>