Review Request 128675: KUrlRequester: fix error box when selecting a file and reopening the file dialog.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128675/
-----------------------------------------------------------

(Updated Sept. 4, 2016, 9:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Jean-Baptiste Mardelle and Kåre Särs.


Changes
-------

Submitted with commit 61d8bb033d4bb6b96bda44440779226efdcc5dba by David Faure to branch master.


Repository: kio


Description
-------

"<foo> is a file, but a folder was expected" was shown because of the
setDirectoryUrl() call added in 580dfd4992ca7d1d4 to fix bug 364719.

This is nowadays unnecessary, apparently due to commit 18e62e7 in plasma-integration,
selectUrl() does the right thing including changing dirs.
The new unittest shows that this works, and that the error above doesn't
happen anymore.


Diffs
-----

  autotests/CMakeLists.txt ffe3a31fbcdb11b9a68d6847c68dad5814f9183b 
  autotests/kurlrequestertest.cpp e2713da20f6f92e9d4bc59e3fbc69d7e4442259d 
  src/widgets/kurlrequester.cpp 217314bc9829b71f11c41a7644cdc75af2b35c6e 
  tests/kurlrequestertest_gui.cpp e412e0e62afbc12e223e0250720eb24f52c95669 

Diff: https://git.reviewboard.kde.org/r/128675/diff/


Testing
-------

The much improved unittest now passes.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160904/b5ea063b/attachment.html>