Review Request 128818: Revert "Remove unused KF5 dependencies"

[Alexander Potashev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128818/#review98839
-----------------------------------------------------------


Ship it!




Doing a self-ship-it because it's trivial.

- Alexander Potashev


On Сен. 3, 2016, 12:11 п.п., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128818/
> -----------------------------------------------------------
> 
> (Updated Сен. 3, 2016, 12:11 п.п.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Andreas Sturmlechner.
> 
> 
> Repository: kross
> 
> 
> Description
> -------
> 
> This reverts commit ce2a58313fbeaee6482c9718ce4dfdf5cc190875.
> 
> Rationale:
> 
>   kross/src/ui/actioncollectionview.cpp uses
>   1. KComboBox from KCompletion,
>   2. KMessageBox from KWidgetsAddons,
>   3. KActionCollection from KXmlGui.
> 
>   KrossUi compiled without problem because some other dependencies (e.g.
>   KParts) linked to these 3 libraries publicly (in the sense of CMake
>   keywords PUBLIC/PRIVATE/INTERFACE).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 53965efbbe72746f5dc6528686d4c8d965f0097a 
> 
> Diff: https://git.reviewboard.kde.org/r/128818/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160903/337eb80c/attachment.html>