Review Request 128232: The default level for logging categories should be Info rather than Warning.

David Faure faure at kde.org
Fri Sep 2 14:36:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128232/
-----------------------------------------------------------

(Updated Sept. 2, 2016, 2:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules, KDE Frameworks and David Edmundson.


Changes
-------

Submitted with commit 413eb26f5d9e7a7f174509f8a16d057d5c0e6578 by David Faure to branch master.


Repository: extra-cmake-modules


Description
-------

The whole point of Info is to be used by apps who want to print out some
info for the user, not disabled by default.

Example use case: ksmserver could output the name of the autostart
files it's starting, so user can check their own scripts are started,
and associate any errors with the corresponding script.

In other words:
Debug = debugging for the developer
Info = debugging for the user :-)

This commit shows the benefit of having a central place for changing this
(many category definitions do not use this macro though)


Diffs
-----

  modules/ECMQtDeclareLoggingCategory.cmake c125949a46c4b83544413f23d5e04b2d8ea2c4cf 

Diff: https://git.reviewboard.kde.org/r/128232/diff/


Testing
-------

The autotests still pass -- somewhat to my surprise ;-)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160902/2a114a14/attachment.html>


More information about the Kde-frameworks-devel mailing list