Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[Albert Astals Cid]

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote:
> > +1, fixes the Gwenview case. I get a warning with Dolphin, but it looks unrelated: http://i.imgur.com/ZF454gn.png

No, that's actually a problem with my code being too strict, dolphin alternates the enabledness of the actions that share the shortcut so that is fine, i've made it so that my code only checks for enable actions sharing shortcuts (of course it does not re-check each time the enabled status changes so the app at some point may break it, but i'm hoping that if someone has been smart enough to play with enable/disable actions they checked the shortcuts don't collide)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review100448
-----------------------------------------------------------


On Oct. 31, 2016, 5:24 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 5:24 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will only show up when someone tries to use the shortcut, so it is relatively easy to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of edit_cut, just give it away, since it's usually Shift+Delete being fought over.
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> -------
> 
> gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if you remove the 
>   if (action == editCutAction || existingShortcutAction == editCutAction) {
> part, you get warning about the actions involved
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161031/c0d843f6/attachment.html>