Review Request 129205: [kcoredirlister] Ability to watch files changes

[Anthony Fieroni]

> On Oct. 31, 2016, 12:38 a.m., David Faure wrote:
> > src/core/kcoredirlister.h, line 429
> > <https://git.reviewboard.kde.org/r/129205/diff/3/?file=482930#file482930line429>
> >
> >     You can't add virtual methods to a public class, this is not binary compatible.
> 
> Anthony Fieroni wrote:
>     That because it's added at last position in public scope, i wasn't sure to add it here or even after qsignals.
> 
> David Faure wrote:
>     No no. Adding a virtual method is binary incompatible, where-ever you put it. (it changes the size of the vtable).
>     Please read https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
>     (but anyway for this particular issue I'm recommending a kded module so this is moot anyway)

I'm readed it, i'm in wrong, forgot for vtable size changes, you're right.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/#review100411
-----------------------------------------------------------


On Oct. 24, 2016, 10:05 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129205/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 10:05 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> David, i will discard review if you don't like it, cause watching files changes can be *really* expensive. I try to:
> 1. to not break abi compability
> 2. to extend filenamesearch with this option
> 3. to fix https://git.reviewboard.kde.org/r/129141/
> 
> 
> Diffs
> -----
> 
>   src/core/kcoredirlister.h e6ba2ac 
>   src/core/kcoredirlister.cpp 508516e 
>   src/core/kcoredirlister_p.h 9a3cc7b 
>   tests/kdirlistertest_gui.h 8316b20 
>   tests/kdirlistertest_gui.cpp 11e89cf 
> 
> Diff: https://git.reviewboard.kde.org/r/129205/diff/
> 
> 
> Testing
> -------
> 
> For 3. i still can't figure out why in filenamesearch signal for delete item(s) is not triggered.
> 1. Search for file (by name) in dolphin
> 2. When appear in view delete him
> 3. Signal ItemsDeleted is not triggered, file stays in the view even if new search is performed and reload is needed. The cache look good, tests pass, works but in filenamesearch.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161031/821ee0ea/attachment-0001.html>