Review Request 129296: Drop unused KConfig dependency

Marco Martin notmart at gmail.com
Mon Oct 31 12:59:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129296/#review100435
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Oct. 31, 2016, 12:52 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129296/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 12:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> The only place KConfig was used was an unused function: `QVariantMap convert(const QString &src)`
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 83bb9a4 
>   autotests/CMakeLists.txt ca839ce 
>   autotests/packagestructuretest.cpp 565c7f4 
>   autotests/querytest.cpp 403364f 
>   src/kpackage/CMakeLists.txt f6668c7 
>   src/kpackage/package.cpp c139031 
>   src/kpackage/packageloader.cpp 264f238 
>   src/kpackage/private/packagejobthread.cpp ec41cdd 
>   src/kpackage/private/packages.cpp 0024058 
>   src/kpackagetool/CMakeLists.txt 4977571 
>   src/kpackagetool/kpackagetool.cpp e98bbe0 
> 
> Diff: https://git.reviewboard.kde.org/r/129296/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tests still pass, everything makes sense.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161031/1e654251/attachment.html>


More information about the Kde-frameworks-devel mailing list