Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).
Albert Astals Cid
aacid at kde.org
Sun Oct 30 11:09:00 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129244/#review100397
-----------------------------------------------------------
src/solid/devices/backends/udisks2/udisksblock.cpp (line 21)
<https://git.reviewboard.kde.org/r/129244/#comment67380>
Given you're using
if defined(Q_OS_FREEBSD)
everywhere else, i'd be happier if you applied the same pattern here
- Albert Astals Cid
On Oct. 23, 2016, 1:16 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129244/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2016, 1:16 p.m.)
>
>
> Review request for KDE Frameworks and Solid.
>
>
> Repository: solid
>
>
> Description
> -------
>
> This patch makes Solid UDisks2 backend compile on FreeBSD.
>
>
> Diffs
> -----
>
> src/solid/devices/CMakeLists.txt e1f3f6e
> src/solid/devices/backends/udisks2/udisksblock.h 123e204
> src/solid/devices/backends/udisks2/udisksblock.cpp 76cfc21
> src/solid/devices/backends/udisks2/udisksopticaldisc.h f8dd59a
> src/solid/devices/backends/udisks2/udisksopticaldisc.cpp a9d9c6b
> src/solid/devices/backends/udisks2/udisksstoragedrive.h be24c7f
> src/solid/devices/backends/udisks2/udisksstoragedrive.cpp af49063
>
> Diff: https://git.reviewboard.kde.org/r/129244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gleb Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/ef6b27e9/attachment.html>
More information about the Kde-frameworks-devel
mailing list