Review Request 129236: KAuth: make sure we can do more than one request

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129236/#review100375
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Oct. 26, 2016, 11:15 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129236/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2016, 11:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Olivier Goffart.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> It was failing because subsequent connects return false.
> Only try to catch the error if a problem was reported.
> 
> Declares some enums so they print something when on QDebug.
> Outputs errors into warnings instead of debug.
> Removes some tr() string puzzles.
> 
> Fixes a behavior change introduced in QtDBus by:
> https://code.qt.io/cgit/qt/qtbase.git/commit/?h=dev&id=6f275a4beb9a42b9d5ac99682ce9939a66239778
> https://codereview.qt-project.org/#/c/161325/
> 
> 
> Diffs
> -----
> 
>   autotests/HelperTest.cpp 8050a06 
>   src/backends/dbus/DBusHelperProxy.cpp c60def8 
>   src/kauthaction.h 96f550b 
>   src/kauthexecutejob.cpp 2901e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/129236/diff/
> 
> 
> Testing
> -------
> 
> Now my snap helper can install and then uninstall an application right away.
> Unit tests pass on my system.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161028/a2de7d69/attachment-0001.html>