Review Request 129275: StoredTransferJob: add failing test case
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Oct 28 22:11:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129275/#review100373
-----------------------------------------------------------
autotests/jobtest.cpp (line 303)
<https://git.reviewboard.kde.org/r/129275/#comment67367>
Why QXmlStreamWriter? Maybe it's a bug in QXmlStreamWriter?
- Aleix Pol Gonzalez
On Oct. 28, 2016, 5:28 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129275/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2016, 5:28 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> https://bugs.kde.org/show_bug.cgi?id=368314 seems to be an actual bug in KIO, rather than a regression in kwalletmanager. I reproduced the bug in a test case: basically `StoredTransferJob` fails to copy a QTemporaryFile when the file has been written by a QXmlStreamWriter (destination file is created, but empty).
>
> If we write to the temp file using a QTextStreamer instead, everything works as expected...
>
>
> Diffs
> -----
>
> autotests/jobtest.h 5687b4a448d26d703d33603e5a0939bc4f8c77b4
> autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2
>
> Diff: https://git.reviewboard.kde.org/r/129275/diff/
>
>
> Testing
> -------
>
> jobtest still passes (with one expected failure).
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161028/fd8314bd/attachment.html>
More information about the Kde-frameworks-devel
mailing list