Review Request 129262: Properly finish DropJobs when triggered is not emitted

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129262/
-----------------------------------------------------------

(Updated Oct. 28, 2016, 9:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 508720091088bb605fb153b3b547fd2cc7a130f4 by Elvis Angelaccio to branch master.


Bugs: 363936
    https://bugs.kde.org/show_bug.cgi?id=363936


Repository: kio


Description
-------

If the user closes a DndPopupMenu without triggering an action, the DropJob never emits the result signal. This results in Dolphin hangs (see bug 363936).

This patch uses a boolean flag to track whether an action has been triggered in the job's popup menu.
If the flag is false and the menu gets deleted, we need to manually emit the result signal.

QMenu emits `aboutToHide` before `triggered`, so I had to use a QTimer as workaround. I'm not sure if there is a better way to do this...


Diffs
-----

  src/widgets/dropjob.cpp f033bfb5318624836d8b83c6783cf998990dcc02 

Diff: https://git.reviewboard.kde.org/r/129262/diff/


Testing
-------

Make sure https://bugs.kde.org/show_bug.cgi?id=363936 is fixed.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161028/8a980668/attachment.html>