[Differential] [Request, 70 lines] D3178: Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES

apol (Aleix Pol Gonzalez) noreply at phabricator.kde.org
Thu Oct 27 14:40:33 UTC 2016


apol created this revision.
apol added a reviewer: Frameworks.

REVISION SUMMARY
  Instead of having an odd fake of it. Will help some required
  refactorings and already showed some issues, fixed by this patch,
  namely:
  
  - don't use string(regex replace) to extract a string from another
  
  string. in case it doesn't match it will offer the whole content which
  is never what we want.
  
  - messages(ERROR), the correct parameter is FATAL_ERROR, cmake
  
  understands "ERROR" as mere output string
  
  - turn the macro into a function, otherwise 2 calls in the same
  
  subdirectory are dangerous.
  
  CCBUG: 371562

TEST PLAN
  tests still pass, projects that use the macro still build

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3178

AFFECTED FILES
  KF5ConfigMacros.cmake
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test1.kcfgc
  autotests/kconfig_compiler/test12.kcfgc
  autotests/kconfig_compiler/test13.kcfgc
  autotests/kconfig_compiler/test9.kcfgc
  autotests/kconfig_compiler/test_qdebugcategory.kcfgc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161027/db2555b9/attachment.html>


More information about the Kde-frameworks-devel mailing list