Review Request 129259: Fix the buffersize in certain situations.

taro yamada archer_ame at yahoo.co.jp
Thu Oct 27 04:58:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129259/
-----------------------------------------------------------

(Updated Oct. 27, 2016, 4:58 a.m.)


Review request for KDE Frameworks.


Bugs: 369275
    https://bugs.kde.org/show_bug.cgi?id=369275


Repository: kio


Description
-------

Currently, KIO uses lstat to get the buffersize for readlink.
But in certain situations, it returns inappropriate value.

For example, "/proc/self" or "/sys/bus/cpu/devices/*" returns its size is 0 , and then readlink fails with EINVAL.(so link won't be shown in kde application.)
TMSU seems it returns its target's actual filesize insted of the link's filesize itself.

This patch changes the buffersize to 1024 bytes if it is 0.
And later truncate it to actual size.


Diffs (updated)
-----

  src/ioslaves/file/file.cpp 8b17d31 

Diff: https://git.reviewboard.kde.org/r/129259/diff/


Testing
-------


Thanks,

taro yamada

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161027/7b3df771/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list