Review Request 129236: KAuth: make sure we can do more than one request
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Oct 26 12:29:13 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129236/
-----------------------------------------------------------
(Updated Oct. 26, 2016, 2:29 p.m.)
Review request for KDE Frameworks.
Changes
-------
Fixed unit tests on my set up, includes another patch WRT debug information, also relevant.
Repository: kauth
Description (updated)
-------
It was failing because subsequent connects return false.
Only try to catch the error if a problem was reported.
Declares some enums so they print something when on QDebug.
Outputs errors into warnings instead of debug.
Removes some tr() string puzzles.
Diffs (updated)
-----
src/backends/dbus/DBusHelperProxy.cpp c60def8
src/kauthaction.h 96f550b
src/kauthexecutejob.cpp 2901e3b
Diff: https://git.reviewboard.kde.org/r/129236/diff/
Testing (updated)
-------
Now my snap helper can install and then uninstall an application right away.
Unit tests pass on my system.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161026/a30a5487/attachment.html>
More information about the Kde-frameworks-devel
mailing list