Review Request 129260: Add find module for QtPlatformSupport
Kai Uwe Broulik
kde at privat.broulik.de
Wed Oct 26 09:17:57 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/
-----------------------------------------------------------
(Updated Okt. 26, 2016, 9:17 vorm.)
Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
Changes
-------
* Apply patch by Hrvoje, thanks!
After adjusting CMakeLists to use Qt5::PlatformSupport and the include private dirs it works with both Kwin and plasma-integration
Repository: extra-cmake-modules
Description
-------
Comes from KWin and will eventually be used in Plasma Integration, hence moving it to extra-cmake-modules.
Diffs (updated)
-----
find-modules/FindQt5PlatformSupport.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129260/diff/
Testing
-------
Removed it from KWin, built KWin, worked.
Built plasma-integration with QDBusMenu private stuff, worked, although includes there sometimes omit the QtPlatformSupport/ prefix but this is an upstream issue since it works with the files Kwin includes.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161026/3bee4013/attachment.html>
More information about the Kde-frameworks-devel
mailing list