Review Request 129260: Add find module for QtPlatformSupport

[Hrvoje Senjan]

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > <https://git.reviewboard.kde.org/r/129260/diff/1/?file=482953#file482953line75>
> >
> >     Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as Qt5PlatformSupport_INCLUDE_DIR?
> 
> Kai Uwe Broulik wrote:
>     I suppose? Dunno, I just copied it from KWin and I know nothing about CMake syntax.

Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
Also, IMO it's a better idea to include ECMQueryQmake and use e.g. query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
-----------------------------------------------------------


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence moving it to extra-cmake-modules.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> -------
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although includes there sometimes omit the QtPlatformSupport/ prefix but this is an upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161025/592649b3/attachment.html>