Review Request 129260: Add find module for QtPlatformSupport
Martin Gräßlin
mgraesslin at kde.org
Tue Oct 25 11:21:54 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100255
-----------------------------------------------------------
+1
- Martin Gräßlin
On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2016, 1:21 p.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Comes from KWin and will eventually be used in Plasma Integration, hence moving it to extra-cmake-modules.
>
>
> Diffs
> -----
>
> find-modules/FindQt5PlatformSupport.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
>
>
> Testing
> -------
>
> Removed it from KWin, built KWin, worked.
>
> Built plasma-integration with QDBusMenu private stuff, worked, although includes there sometimes omit the QtPlatformSupport/ prefix but this is an upstream issue since it works with the files Kwin includes.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161025/579bc086/attachment.html>
More information about the Kde-frameworks-devel
mailing list