Review Request 129253: Support non integer scale factors in kiconengine

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129253/#review100239
-----------------------------------------------------------



> didn't look blurry on mouseover

Did you test particular theme or can we assume lines are sharp regardless of theme?

(for the record, when I removed 24x24 icons I got blurry icons for default Windows style on Windows as 24px is a standard for toolbars)

- Jarosław Staniek


On Oct. 24, 2016, 5:06 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129253/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Support non integer scale factors in kiconengine
> 
> 
> Diffs
> -----
> 
>   src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe 
> 
> Diff: https://git.reviewboard.kde.org/r/129253/diff/
> 
> 
> Testing
> -------
> 
> Ran system settings with QT_SCALE_FACTOR=2.3 
> didn't look blurry on mouseover
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161024/22c1dc04/attachment.html>