Review Request 129188: Add documentation for the GenerateProperties option

[Elvis Angelaccio]

> On Oct. 16, 2016, 2:38 p.m., Aleix Pol Gonzalez wrote:
> > src/kconfig_compiler/README.dox, line 216
> > <https://git.reviewboard.kde.org/r/129188/diff/2/?file=482239#file482239line216>
> >
> >     Are you sure this is needed? maybe we could make it so it's not needed? Looks the kind of thing that will generate crazy errors, hard to figure out.
> 
> Elvis Angelaccio wrote:
>     It won't compile without (unless I'm doing something wrong). GenerateProperties adds "include xxx.moc" in the generated xxx.cpp file, but the compiler doesn't find xxx.moc without the GENERATE_MOC option. I don't know exactly how cmake handles the moc, but maybe xxx.{h,cpp} are generated after automoc has already been run?
> 
> Albert Astals Cid wrote:
>     @Aleix: Honestly i think you're putting an unreasonable request to Elvis, he's just documenting a missing feature from the docs, and while doing that you're asking him to fix a bug, that while unrelated is in my opinion out of scope for this review request, i think what's fair is
>     
>     * Commit this
>     * Open a bug about the need of using GENERATE_MOC and see if we can get that fixed.
>     
>     What do you think?
> 
> Aleix Pol Gonzalez wrote:
>     Yes, I guess you are right, it's out of scope. If you can commit this, it's already a step forward. If you can create a bug and assign it to me, that would be perfect.

There you go :) https://bugs.kde.org/show_bug.cgi?id=371562


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129188/#review100043
-----------------------------------------------------------


On Oct. 24, 2016, 9:45 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129188/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 9:45 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The `GenerateProperties` option is missing from: https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html
> 
> This patch explains what the option does and how to use it.
> 
> 
> Diffs
> -----
> 
>   src/kconfig_compiler/README.dox b9606f1d157229a22afbeaea7d56ee95732762a2 
> 
> Diff: https://git.reviewboard.kde.org/r/129188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161024/00e2eb96/attachment.html>